Skip to content

Allow null 'format' in DateRangeAggregation #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: 7.2
Choose a base branch
from
Open

Allow null 'format' in DateRangeAggregation #352

wants to merge 2 commits into from

Conversation

pmishev
Copy link
Contributor

@pmishev pmishev commented Mar 11, 2021

Allow null 'format' in DateRangeAggregation

Without this, calling:

        $ranges[] = ['from' => time()-1000, 'to' => time(), 'key' => 'time_range'];
        $rangeAgg = new DateRangeAggregation('myagg', 'created', null, $ranges, true);

results in an exception, but it shouldn't as format is optional.

@pmishev
Copy link
Contributor Author

pmishev commented Jun 9, 2022

Have you considered merging this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@pmishev